Skip to content

Add support for displaying helpPopover next to the button in NoData#2509

Closed
VedanshAgrawal22 wants to merge 5 commits into
mainfrom
2508-add-support-for-displaying-a-help-popover-next-to-the-button-in-nodata-component
Closed

Add support for displaying helpPopover next to the button in NoData#2509
VedanshAgrawal22 wants to merge 5 commits into
mainfrom
2508-add-support-for-displaying-a-help-popover-next-to-the-button-in-nodata-component

Conversation

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor

@VedanshAgrawal22 VedanshAgrawal22 commented Jun 25, 2025

Description
Added support for displaying a help popover next to the button in NoData component

Checklist

- [ ] I have added proper data-cy and data-testid attributes.

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@VedanshAgrawal22 VedanshAgrawal22 self-assigned this Jun 25, 2025
@VedanshAgrawal22 VedanshAgrawal22 added the patch Releases small requests or bug fixes. label Jun 25, 2025
@neetodeploy neetodeploy Bot had a problem deploying to neeto-ui-agsb-pr-2509 June 25, 2025 18:43 Failure
@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2509 June 25, 2025 20:42 Inactive
@neetodeploy neetodeploy Bot had a problem deploying to neeto-ui-agsb-pr-2509 June 25, 2025 20:43 Failure
@neetodeploy neetodeploy Bot had a problem deploying to neeto-ui-agsb-pr-2509 June 26, 2025 03:13 Failure
@neetodeploy neetodeploy Bot temporarily deployed to neeto-ui-agsb-pr-2509 June 26, 2025 03:21 Inactive
@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

Closing and reopening the PR to trigger redeployment.

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

Closing and reopening the PR to trigger redeployment.

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

VedanshAgrawal22 commented Jun 26, 2025

@josephmathew900 _a Could you please review this? The branch is not getting deployed, which might be due to the organization change.

Copy link
Copy Markdown
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VedanshAgrawal22 _a Can you just explain the use case? There is enough space to show the information, so why do we need the tooltip?

popoverProps: {
title: "What is KB keywords?",
description:
"Keywords represent the key concepts of an article. These will be shown on the KB and will be used for SEO",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is a story, it would be better if the content is related. The empty state is about tickets, but the tooltip content is about keywords

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@VedanshAgrawal22 _a Can you just explain the use case? There is enough space to show the information, so why do we need the tooltip?

@josephmathew900: Are you asking about the requirement of a popover even though we have a tooltip already? If so, then the reason is that we need to switch to help popover instead of tooltip as a part of this issue. We are making this switch because help popover would also allow us to display help article links to guide the users.
Also, should I be adding this as a description to this issue and future issues similar to this? I didn't add a description explicitly because the reference issue already has this mentioned.

@josephmathew900
Copy link
Copy Markdown
Contributor

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@josephmathew900: Understood. There are two instances where the Add question button would be disabled. In the first instance which is shown in the image in the reference issue, they are suggesting adding a help icon popover.
For the second instance (which requires a change in NoData component, I decided to add a help icon popover to maintain consistency with the first instance.

@josephmathew900
Copy link
Copy Markdown
Contributor

@VedanshAgrawal22 Please discuss with Praveen also, if the help popover is needed, you can update the story and assign the PR back to me.

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

@praveen-murali-ind
Copy link
Copy Markdown
Contributor

@VedanshAgrawal22 _a @josephmathew900 Since this isn't a common use case, I think it's fine to use the description field to maintain consistency with other instances.

Screenshot 2025-06-27 at 11 13 43 AM

Storybook example

@VedanshAgrawal22
Copy link
Copy Markdown
Contributor Author

Closing this PR as we have decided to use the description field to show the help link instead of adding a tooltip.

cc: @josephmathew900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Releases small requests or bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for displaying a help popover next to the button in NoData component

3 participants