Skip to content

Added logic to handle table length and the RuboCop failures in the down method #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 20, 2024
Merged

Added logic to handle table length and the RuboCop failures in the down method #12

merged 15 commits into from
Nov 20, 2024

Conversation

AbhayVAshokan
Copy link
Contributor

@AbhayVAshokan AbhayVAshokan commented Nov 20, 2024 •
edited
Loading

Fixes #8
Fixes #11

  • Bumped Ruby version to 3.3.5.
  • Truncate table names to prevent exceeding the default limit of 63 characters.
  • Prevented calling the RuboCop rules inside the down method.
  • Added GitHub workflows to automatically publish a new version on merge.

@AbhayVAshokan _a

@neetodeploy neetodeploy bot temporarily deployed to rubocop-neeto-5hsm-pr-12 November 20, 2024 07:42 Inactive
@neetodeploy neetodeploy bot had a problem deploying to rubocop-neeto-5hsm-pr-12 November 20, 2024 07:48 Failure
@neetodeploy neetodeploy bot temporarily deployed to rubocop-neeto-5hsm-pr-12 November 20, 2024 07:52 Inactive
@neetodeploy neetodeploy bot temporarily deployed to rubocop-neeto-5hsm-pr-12 November 20, 2024 07:53 Inactive
@neetodeploy neetodeploy bot temporarily deployed to rubocop-neeto-5hsm-pr-12 November 20, 2024 07:57 Inactive
@AbhayVAshokan AbhayVAshokan added patch backend Deals with Ruby & Rails code majorly. labels Nov 20, 2024
@neetodeploy neetodeploy bot temporarily deployed to rubocop-neeto-5hsm-pr-12 November 20, 2024 12:40 Inactive
@AbhayVAshokan AbhayVAshokan merged commit 3b6fe8f into main Nov 20, 2024
1 check passed
@AbhayVAshokan AbhayVAshokan deleted the 11-handle-long-table-names branch November 20, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AbhayVAshokan AbhayVAshokan

Labels

backend Deals with Ruby & Rails code majorly. patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot deprecate tables with long names Do not execute the unsafe table deletion and unsafe column deletion rules in the down method

1 participant

@AbhayVAshokan