Conversation
![neeto-bugwatch[bot]](https://avatars.githubusercontent.com/in/1747066?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 NeetoBugWatch Review
I've analyzed your pull request and found some potential improvements that might be worth considering. Please review the specific line comments below for helpful suggestions.
💡 To trigger a re-review of this PR, add a comment with the keyword neeto-bugwatch-run anywhere in the comment body.
| (send (const {nil? cbase} :ENV) _ ...) | ||
| PATTERN | ||
|
|
||
| def on_send(node) |
There was a problem hiding this comment.
Using on_send catches explicit method calls like ENV['KEY'], but misses cases where ENV is aliased (e.g., x = ENV; x['KEY']) or passed as an argument. Consider implementing on_const to flag any usage of the ENV constant if strict prohibition is desired.
There was a problem hiding this comment.
I feel this was a good review comment by NeetoBugWatch. I feel the following will be missed:
config = ENV
config['API_KEY']
do_something_with(ENV)
|
@yedhink _a Can you please review? Here is the demo: https://prabodh-kumar-panda.neetorecord.com/watch/8db62dfdfad28b313955 |
yedhink
left a comment
yedhink
left a comment
There was a problem hiding this comment.
@prabodh-panda _a Have added one query. Once addressed go ahead and merge it.
| (send (const {nil? cbase} :ENV) _ ...) | ||
| PATTERN | ||
|
|
||
| def on_send(node) |
There was a problem hiding this comment.
I feel this was a good review comment by NeetoBugWatch. I feel the following will be missed:
config = ENV
config['API_KEY']
do_something_with(ENV)
2 participants
Checklist
is required).
Reviewers