Skip to content

fix possible leakage of secrets in debug logging #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drornir wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −4
Open

fix possible leakage of secrets in debug logging #5973

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41f4036
fix possible leakage of secrets in debug logging
drornir Nov 22, 2025
dc6d4d5
fixed %t to masked %s
drornir Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/runner/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,11 @@ type expressionEvaluator struct {

func (ee expressionEvaluator) evaluate(ctx context.Context, in string, defaultStatusCheck exprparser.DefaultStatusCheck) (interface{}, error) {
logger := common.Logger(ctx)
logger.Debugf("evaluating expression '%s'", in)
printableInput := regexp.MustCompile(`::add-mask::.*`).ReplaceAllString(in, "::add-mask::***")
logger.Debugf("evaluating expression '%s'", printableInput)
evaluated, err := ee.interpreter.Evaluate(in, defaultStatusCheck)

printable := regexp.MustCompile(`::add-mask::.*`).ReplaceAllString(fmt.Sprintf("%t", evaluated), "::add-mask::***)")
logger.Debugf("expression '%s' evaluated to '%s'", in, printable)
logger.Debugf("expression '%s' evaluated to '%t'", printableInput, evaluated)
Copy link
Contributor

@ChristopherHX ChristopherHX Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluated being the text of run: , not only true or false

Copy link
Author

@drornir drornir Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik '%t' converts it to a boolean.
Would you rather I masked it and printed it out as string?

Copy link
Author

@drornir drornir Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I realized it would print the string with an %!t(string=..., fixed


return evaluated, err
}
Expand Down