refactor: extract buildNeedsAndStrategy helper function#5990
Open
Mohamed-Elwasila wants to merge 1 commit intonektos:masterfrom
Open
refactor: extract buildNeedsAndStrategy helper function#5990Mohamed-Elwasila wants to merge 1 commit intonektos:masterfrom
Mohamed-Elwasila wants to merge 1 commit intonektos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildNeedsAndStrategy()helper functionNewExpressionEvaluatorWithEnv()andnewStepExpressionEvaluator()to use the new helperMotivation
There was duplicate code (~20 lines) in two functions that built the same needs and strategy maps for expression evaluation. This refactoring improves maintainability and reduces the chance of inconsistencies.
Test Plan
go build ./...)golangci-lint run)go fmtFixes TODO items in pkg/runner/expression.go:37 and pkg/runner/expression.go:124