refactor: simplify workflow file loading#6017
Open
nikpivkin wants to merge 1 commit intonektos:masterfrom
Open
refactor: simplify workflow file loading#6017nikpivkin wants to merge 1 commit intonektos:masterfrom
nikpivkin wants to merge 1 commit intonektos:masterfrom
Conversation
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6017 +/- ##
==========================================
+ Coverage 74.65% 76.76% +2.11%
==========================================
Files 73 74 +1
Lines 11139 9203 -1936
==========================================
- Hits 8316 7065 -1251
+ Misses 2186 1503 -683
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
It looks like the failed test is not related to changes in the code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the workflow file loading logic.
filepath.Walkwithfilepath.WalkDirsince it was introduced in Go 1.16 and is more efficient, also returningfs.DirEntrywithout extrafs.FileInfoconversion.WorkflowFilestoWorkflowFilebecause the structure represents a single file rather than a collection.filepath.WalkDiris used regardless of whether the path is a file or a directory.os.ReadDir.