fix: Handle Symfony serializer datetime_format
context for date formatting
#2551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Symfony serializer supports a
Context
attribute which can provide details for how to normalize a property. Specifically, adatetime_format
key can be provided to specify how to format aDateTime
field. This PR handles adatetime_format
value ofY-m-d
and sets theformat
todate
, rather than the current incorrect value ofdate-time
.I don't believe there are any issues this PR will close, though this was brought up in a comment at #2145 (comment)
What type of PR is this? (check all applicable)
Checklist
docs/
)CHANGELOG.md
)Uncertainties
SymfonyConstraintAnnotationReader
), and making this a more genericSymfonyAnnotationReader
class. The class was documented as@internal
so I don't believe this would be a breaking change. If you'd rather I go down a different route, please give me some pointers of where/how you'd like this implemented.