Conversation
IoannisPanagiotas
force-pushed
the
enable-similarity-algos
branch
17 times, most recently
from
33ccc47 to
071d5e7
Compare
IoannisPanagiotas
changed the title
| "description": "Property name to use for identifying nodes (e.g., 'name', 'Name', 'title'). Use get_node_properties_keys to find available properties.", | ||
| }, | ||
| }, | ||
| "required": ["sourceNodeFilter", "targetNodeFilter"], |
There was a problem hiding this comment.
I believe they still need to be required? https://neo4j.com/docs/graph-data-science/current/algorithms/filtered-node-similarity/
| }, | ||
| }, | ||
| "required": ["sourceNodeFilter", "targetNodeFilter", "nodeProperties"], | ||
| "required": ["nodeProperties"], |
There was a problem hiding this comment.
I think they are still required https://neo4j.com/docs/graph-data-science/current/algorithms/filtered-knn/
There was a problem hiding this comment.
the documentation is wrong!
if both are required, then that would mean you would need to specify both each time .e., you would not be able to add only source filter alone etc.
i think the docs are such that they reflect if you dont need to use them just go for normal similarity algo.
see also the tests in test_similarity.algos they test solo these calls etc.
There was a problem hiding this comment.
Then I think we can just have two tools, node_sim and kNN, and have the optional filters?
We could also "fix" the official doc.
There was a problem hiding this comment.
fine by me
| { | ||
| "nodeIdentifierProperty": "name", | ||
| "topK": 3, | ||
| "sourceNodeFilter": ["Acton Town"], |
There was a problem hiding this comment.
but this test suggest without targetNodeFilter (which defaults to None in the code), it still works?
IoannisPanagiotas
force-pushed
the
enable-similarity-algos
branch
from
9bb96ea to
fe040b9
Compare
IoannisPanagiotas
force-pushed
the
enable-similarity-algos
branch
from
fe040b9 to
ccf7e6e
Compare
IoannisPanagiotas
force-pushed
the
enable-similarity-algos
branch
5 times, most recently
from
65cc3d2 to
a59db85
Compare
IoannisPanagiotas
force-pushed
the
enable-similarity-algos
branch
from
a59db85 to
f7af9b7
Compare
2 participants
No description provided.