This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Enable to use only topK param with similarity algos#784
Open
tomasonjo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an option how to allow users to use only topK parameter as for example:
CALL algo.similarity.cosine.stream(data, {topK:1})Idea came from #729 and #730 and this PR is a nice and clean solution,
which I think improves user experience and causes less confusion with the user. On the other hand, there are cases where dissimilar relationships would get written back because we don't limit it anymore when providing topK param. This should be more of a problem with smaller datasets and with large datasets this won't usually happen in my experience.
What are your thoughts @mneedham @jexp?
Will add the code to all similarity algos if this is ok.