Implement #820: Add support for INCLUDES/INCLUDES_ALL/INCLUDES_ANY operators in cypher filters

[wbenbihi]

This pull request adds support for the INCLUDES/INCLUDES_ALL/INCLUDES_ANY operators in cypher filters. It includes changes to the match.py file in the neomodel/sync_ directory. The operators allow for filtering based on array values, such as checking if an array contains a specific value or if it contains all or any of a set of values. This enhancement improves the functionality and flexibility of the cypher filters in the codebase.

These operators are usable both in NodeSet.filter & RelationshipManager.match. It is compatible with neomodel.Q filters for NodeSet.filter method.

Issue #820 describes the feature request.

[wbenbihi]

Quality Gate failed

Failed conditions 48.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

It appears most of the duplicated code comes from the Async to Sync transpiling. Should the _sync updates be commited in PRs or the CI takes care of it?

[mariusconjeaud]

Hello ! Thank you for your PR.
The way the transpiling works is that you should only write code in the async_ part, and the sync_ part will be generated automatically.

[wbenbihi]

Hello ! Thank you for your PR. The way the transpiling works is that you should only write code in the async_ part, and the sync_ part will be generated automatically.

Thank you for the clarification. I will revert the code from the sync_ modules

[mariusconjeaud]

Thank you for the thorough testing !

I just realized I misled you earlier. You should push the sync_ code generated automatically by the pre-commit hooks. I only meant that you should write async_ and let those do the work, instead of the other way around.
And yes, sadly it creates code duplication but that is OK in this context. Maybe I should find a way to have SonarCloud ignore the content of sync_ since it's 100% transpiled.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[wbenbihi]

No problem. I just added the sync_ file with make-unasync as described in the contributing guide. The SonarCloud should trigger a Code Duplication warning. I'll let you tell me if the PR is approved.

[mariusconjeaud]

I think I found the way to make Sonarcloud ignore the sync_ folders during the Code Duplication step ! So it's all good now.

[mariusconjeaud]

Did you read my comments on the PR ?

Also, could you rebase from the rc/5.3.3 branch ? I fixed a bug in a test that was coming from the latest version of Neo4j changing the default ordering - and the test was relying on the exact order without enforcing it...

[whisust]

Hi, any update on this PR? She is (long) awaited :)
Thanks