Skip to content

Fix metadata for Hoe #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Fix metadata for Hoe #255

merged 4 commits into from
May 20, 2025

Conversation

nsauk
Copy link
Contributor

@nsauk nsauk commented May 20, 2025

In #238 I removed a line that was used by Hoe to set the gem's metadata, therefore it fails on rake tasks.

I was unable to quickly find a way to put this into the Hoe config (self.homepage = didn't work), so this PR just adds the line back. Double whitespace before :: as in the previous version of the README aren't required.

@nsauk nsauk changed the base branch from 4.4 to 5.0 May 20, 2025 16:53
@nsauk nsauk requested a review from klobuczek May 20, 2025 16:53
@nsauk nsauk closed this May 20, 2025
@nsauk nsauk reopened this May 20, 2025
@nsauk
Copy link
Contributor Author

nsauk commented May 20, 2025

About the latest commit: the 'home' key in the urls hash has to be a string because of https://github.com/seattlerb/hoe/blob/b80a4958591d7b7cdfbf6c9e743f76e6558f6dac/lib/hoe.rb#L549, otherwise it fills s.homepage but not s.metadata["homepage_uri"] in .gemspec

@klobuczek klobuczek merged commit 62f8b6f into 5.0 May 20, 2025
9 of 15 checks passed
@klobuczek klobuczek deleted the readme-hoe-fix branch May 20, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants