Wrapper for execute_read/write transaction #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klobuczek
requested changes
May 23, 2025
Comment on lines
+10
to
+12
| def run(query, **parameters) | ||
| @tx.run(query, **parameters) | ||
| end |
There was a problem hiding this comment.
Use delegate :run, to: :@tx at the top of the class definition
| @@ -48,11 +48,11 @@ def write_transaction(**config, &block) | |||
| end | |||
|
|
|||
| def execute_read(**config, &block) | |||
| transaction(AccessMode::READ, **config, &block) | |||
| transaction(AccessMode::READ, **config, &(->(tx) { block.call(DelegatingTransaction.new(tx)) })) | |||
There was a problem hiding this comment.
We have a nicer more idiomatic syntax for that,
Suggested change
| transaction(AccessMode::READ, **config, &(->(tx) { block.call(DelegatingTransaction.new(tx)) })) | |
| transaction(AccessMode::READ, **config) { block.call(DelegatingTransaction.new(it)) } |
Alternatively composition, bonus points for investigation. Personally never used it before:
Suggested change
| transaction(AccessMode::READ, **config, &(->(tx) { block.call(DelegatingTransaction.new(tx)) })) | |
| transaction(AccessMode::READ, **config, &(DelegatingTransaction.method(:new) >> block)) |
Looking at it I don't think it beats the former basic ruby syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper for execute_read/write (mri implementation) #251