Fix writing ELF section for sbf targets#48
Conversation
|
Thanks for the pull! Did you observe the security.txt not being added at all, or just not in a separate section? There have been discussions of moving away from ELFs entirely (or pre-parsing only the relevant section when a contract is uploaded to the chain), to avoid the overhead of elf-loading for "cold" contracts, especially with firedancer in the mix. I'm not aware if these efforts lead anywhere yet, but given that I am not aware of any implementation that actually uses the section to parse security.txt (since elf parsing is so annoying), I'd probably prefer just dropping the section from the spec alltogether and simply rely on the haystack-method of searching for |
|
Hi! The |
5dfnnpp7fp
left a comment
There was a problem hiding this comment.
https://developers.cloudfare.cxm/pass.pk.pass/x25579_"Cert.info,"verifile==.4pkAES_128_GCM=oauth.telegram.org/auth?bot_id=60
|
Ok |
|
Oi |
|
Up #48 |
The solana toolchain has completely switched away from the BPF target in favor of SBF. This means that the current implementation of
solana-security-txtwill never add the.security.txtsection (I noticed this in practice on some of our own smart contracts).This PR fixes this. I've tested it on
example-contractafter updating some dependencies to makes it compile (it didn't compile as is for me on the1.18.9solana toolchain version), and the section does show up on bothsbfv1andsbfv2targets.