Skip to content

implement protoc-gen-prost-validate - #107

Open
Adphi wants to merge 1 commit into
neoeinstein:mainfrom
linka-cloud:protoc-gen-prost-validate
Open

implement protoc-gen-prost-validate#107
Adphi wants to merge 1 commit into
neoeinstein:mainfrom
linka-cloud:protoc-gen-prost-validate

Conversation

@Adphi

@Adphi Adphi commented Oct 11, 2024

Copy link
Copy Markdown

Implementation of protoc-gen-prost-validate using prost-validate.

closes #106

@Adphi
Adphi marked this pull request as draft October 11, 2024 13:18
@Adphi Adphi changed the title wip: implement protoc-gen-prost-validate implement protoc-gen-prost-validate Oct 11, 2024
@Adphi
Adphi force-pushed the protoc-gen-prost-validate branch 3 times, most recently from 1a8ca82 to 1729cb7 Compare October 14, 2024 22:44
@Adphi
Adphi force-pushed the protoc-gen-prost-validate branch 2 times, most recently from ee378bb to befe11a Compare June 6, 2025 12:14
@Adphi
Adphi marked this pull request as ready for review June 6, 2025 12:15
@Adphi

Adphi commented Jun 6, 2025

Copy link
Copy Markdown
Author

Hi @neoeinstein !

Could you please take a look at this PR when you have a chance ?
Let me know if you have any feedback or suggestions.

Thanks in advance!

@fenollp

fenollp commented Jun 17, 2025

Copy link
Copy Markdown

FYI @neoeinstein we're a few people already using this and it works great :)

@siennathesane

Copy link
Copy Markdown
Collaborator

Hey hey, I'm a new maintainer now. I've not used prost-validate. I'm open to this on principal but I want to do some research so I can give you a good review.

@siennathesane siennathesane self-assigned this Nov 6, 2025
@siennathesane
siennathesane self-requested a review November 6, 2025 23:47
@Adphi
Adphi force-pushed the protoc-gen-prost-validate branch from befe11a to e0a657b Compare November 26, 2025 09:06
@Adphi
Adphi requested a review from neoeinstein as a code owner November 26, 2025 09:06
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
@Adphi
Adphi force-pushed the protoc-gen-prost-validate branch from e0a657b to 255df13 Compare November 26, 2025 09:08

@siennathesane siennathesane left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about this. It feels like the maintenance burden will be high, esp since there's an 8.5k line test case file with no documentation that I can't tell is hand-generated or not. This feels risky from a maintenance and stability standpoint.

@neoeinstein what do you think?

@Adphi

Adphi commented Dec 16, 2025

Copy link
Copy Markdown
Author

@siennathesane, thanks for taking a look, that’s a fair concern.

For context, the large test file isn’t unique to this PR. The tests are taken directly from prost-validate-tests which themselves are adapted from the original protoc-gen-validate harness tests.

So this is a long-standing, well-tested corpus reused across multiple implementations, rather than new surface area introduced here. The goal was to reduce risk by aligning with existing behavior.

We’re also happy to take on maintenance ourselves, either within this repo or by maintaining our own fork. The main blocker to doing the latter is needing the protoc-gen-prost-validate crate name to publish it.

@siennathesane

siennathesane commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

Hmm... I think there's value for the community, but my biggest concern is the maintenance burden. I would rather own the maintenance of it than have forks so that we can keep stuff useful for everyone and keep all the crates in one place.

I'll make you a deal. If you can come up with a MAINTAINERS.md (or some appropriate name) document for this crate, with all of the instructions on how to maintain the test files, the protobufs, and other general maintenance tasks, I'll approve it. It doesn't need to be 100% perfect, but enough that someone like me can look at it, understand what to do, and get it done.

I'm willing to meet in the middle on this because I think there's value for the community, and I want this project to continue to be the source of that value in the Buf ecosystem. But I need a way to make sure that I, and others, are able to maintain it across versions without anyone having to be an expert, or to put you on the hook for maintaining it. To me, documenting the process feels like a good middle ground.

There are merge conflicts, CI will need to pass (don't worry about the vet job), and other stuff to get it merged, but that's minor imo.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement protoc-gen-prost-validate from newly released prost-validate

3 participants