implement protoc-gen-prost-validate - #107
Conversation
1a8ca82 to
1729cb7
Compare
ee378bb to
befe11a
Compare
|
Hi @neoeinstein ! Could you please take a look at this PR when you have a chance ? Thanks in advance! |
|
FYI @neoeinstein we're a few people already using this and it works great :) |
|
Hey hey, I'm a new maintainer now. I've not used |
befe11a to
e0a657b
Compare
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
e0a657b to
255df13
Compare
siennathesane
left a comment
There was a problem hiding this comment.
I'm on the fence about this. It feels like the maintenance burden will be high, esp since there's an 8.5k line test case file with no documentation that I can't tell is hand-generated or not. This feels risky from a maintenance and stability standpoint.
@neoeinstein what do you think?
|
@siennathesane, thanks for taking a look, that’s a fair concern. For context, the large test file isn’t unique to this PR. The tests are taken directly from prost-validate-tests which themselves are adapted from the original protoc-gen-validate harness tests. So this is a long-standing, well-tested corpus reused across multiple implementations, rather than new surface area introduced here. The goal was to reduce risk by aligning with existing behavior. We’re also happy to take on maintenance ourselves, either within this repo or by maintaining our own fork. The main blocker to doing the latter is needing the |
|
Hmm... I think there's value for the community, but my biggest concern is the maintenance burden. I would rather own the maintenance of it than have forks so that we can keep stuff useful for everyone and keep all the crates in one place. I'll make you a deal. If you can come up with a I'm willing to meet in the middle on this because I think there's value for the community, and I want this project to continue to be the source of that value in the Buf ecosystem. But I need a way to make sure that I, and others, are able to maintain it across versions without anyone having to be an expert, or to put you on the hook for maintaining it. To me, documenting the process feels like a good middle ground. There are merge conflicts, CI will need to pass (don't worry about the vet job), and other stuff to get it merged, but that's minor imo. What do you think? |
Implementation of
protoc-gen-prost-validateusingprost-validate.closes #106