Skip to content

Fix documentation for additionalRuntimeClasspath for <=1.21.9#357

Open
c-Caelum wants to merge 5 commits into
neoforged:mainfrom
c-Caelum:patch-1
Open

Fix documentation for additionalRuntimeClasspath for <=1.21.9#357
c-Caelum wants to merge 5 commits into
neoforged:mainfrom
c-Caelum:patch-1

Conversation

@c-Caelum
Copy link
Copy Markdown

@c-Caelum c-Caelum commented May 30, 2026

When adding libraries via additionalRuntimeClasspath, you must exclude the dependencies and add them back manually. I believe this is because gradle sees it as having already been added, even though it does not handle the transitive dependencies.


Preview URL: https://pr-357.neoforged-docs-previews.pages.dev

When adding libraries via additionalRuntimeClasspath, you must exclude the dependencies and add them back manually. I believe this is because gradle sees it as having already been added, even though it does not handle the transitive dependencies.
@ChampionAsh5357 ChampionAsh5357 added the incorrect Fixes incorrect information. label May 31, 2026
@ChampionAsh5357
Copy link
Copy Markdown
Contributor

Apologies for the late reply. I would stick this block in a warning tag and give a bit more prefix of the explanation that example depends on my_module transitively, meaning the implementation will add it as a compile-time dep. It may even be better to change my_module to something like dependency or something to make it more explicit.

@neoforged-pages-deployments neoforged-pages-deployments Bot deployed to neoforged-docs-previews (Preview) May 31, 2026 17:36 Active
@neoforged-pages-deployments
Copy link
Copy Markdown

Deploying with Cloudflare Pages

Name Result
Last commit: a7be5f24028e212998166b31799c00f076d51cb8
Status: ✅ Deploy successful!
Preview URL: https://40efe02e.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-357.neoforged-docs-previews.pages.dev

@c-Caelum
Copy link
Copy Markdown
Author

c-Caelum commented Jun 1, 2026

Understood. I'll make those changes.

Copy link
Copy Markdown
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things, then all good.

Comment thread toolchain/docs/dependencies/nonmclibs.md Outdated
additionalRuntimeClasspath 'com.example:example:1.0'
}
```
:::warning
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a newline before this.

Comment thread toolchain/docs/dependencies/nonmclibs.md Outdated
Comment thread toolchain/docs/dependencies/nonmclibs.md Outdated
c-Caelum and others added 3 commits June 1, 2026 17:45
Co-authored-by: ChampionAsh5357 <championash5357@gmail.com>
Co-authored-by: ChampionAsh5357 <championash5357@gmail.com>
@c-Caelum
Copy link
Copy Markdown
Author

c-Caelum commented Jun 1, 2026

Okay, I think that's done?

@ChampionAsh5357
Copy link
Copy Markdown
Contributor

Please remove the package-lock.json changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

incorrect Fixes incorrect information.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants