Fix documentation for additionalRuntimeClasspath for <=1.21.9#357
Open
c-Caelum wants to merge 5 commits into
Open
Fix documentation for additionalRuntimeClasspath for <=1.21.9#357c-Caelum wants to merge 5 commits into
c-Caelum wants to merge 5 commits into
Conversation
When adding libraries via additionalRuntimeClasspath, you must exclude the dependencies and add them back manually. I believe this is because gradle sees it as having already been added, even though it does not handle the transitive dependencies.
Contributor
|
Apologies for the late reply. I would stick this block in a |
Deploying with Cloudflare Pages
|
Author
|
Understood. I'll make those changes. |
ChampionAsh5357
requested changes
Jun 1, 2026
Contributor
ChampionAsh5357
left a comment
There was a problem hiding this comment.
Just a few more things, then all good.
| additionalRuntimeClasspath 'com.example:example:1.0' | ||
| } | ||
| ``` | ||
| :::warning |
Contributor
There was a problem hiding this comment.
There should be a newline before this.
Co-authored-by: ChampionAsh5357 <championash5357@gmail.com>
Co-authored-by: ChampionAsh5357 <championash5357@gmail.com>
Author
|
Okay, I think that's done? |
Contributor
|
Please remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding libraries via additionalRuntimeClasspath, you must exclude the dependencies and add them back manually. I believe this is because gradle sees it as having already been added, even though it does not handle the transitive dependencies.
Preview URL: https://pr-357.neoforged-docs-previews.pages.dev