Skip to content

Conversation

@lukebemish
Copy link
Contributor

@lukebemish lukebemish commented Jun 17, 2025

This supersedes and extends #228 to replace RuntimeDistCleaner entirely with a solution that does not involve ASM, uses the manifest file masking of neoforged/NeoFormRuntime#66 and neoforged/NeoGradle#257, and has no effects in prod:

  • The neoforge dev mod candidate locator reads this manifest, and uses it to apply the relevant masking
  • Non-class files are filtered out of the resulting mod jar.
  • Classes are added to a set in an ILaunchPluginService, which throws an exception when one attempts to load one of those classes with the same message as RuntimeDistCleaner would have provided.
  • RuntimeDistCleaner is removed entirely, as it is unnecessary.
  • The relevant test RuntimeDistCleanerTest is replaced with a short test in a userdev dev environment.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Jun 17, 2025

@lukebemish, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 27d7e3637007dee043ef535df798339c6221ff52.

loader (:loader)

  • net/neoforged/fml/common/asm/RuntimeDistCleaner
    • ❗ API class no longer exists

@lukebemish
Copy link
Contributor Author

Err... why does the bot think anything has changed in FMLConfig.ConfigValue? Wacky. But yes, this is indeed breaking.

@neoforged-automation
Copy link

@lukebemish, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Jun 18, 2025
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Jun 18, 2025
@lukebemish lukebemish requested a review from shartte June 19, 2025 01:55
@lukebemish lukebemish requested a review from embeddedt June 19, 2025 02:07
@lukebemish lukebemish marked this pull request as ready for review June 19, 2025 17:13
@Technici4n Technici4n dismissed shartte’s stale review July 2, 2025 21:56

agreed to dismissal on Discord

@Technici4n Technici4n merged commit f11e2e9 into neoforged:main Jul 2, 2025
3 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as FancyModLoader version 9.0.5.

@lukebemish lukebemish deleted the file-masking branch July 2, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants