-
Notifications
You must be signed in to change notification settings - Fork 54
[Breaking] Replacing RuntimeDistCleaner #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@lukebemish, this PR introduces breaking changes.
|
|
Err... why does the bot think anything has changed in |
|
@lukebemish, this pull request has conflicts, please resolve them for this PR to move forward. |
...er/src/main/java/net/neoforged/fml/loading/moddiscovery/locators/NeoForgeDevDistCleaner.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/net/neoforged/fml/loading/moddiscovery/locators/NeoForgeDevDistCleaner.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/moddiscovery/locators/NeoForgeDevProvider.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/net/neoforged/fml/loading/moddiscovery/locators/NeoForgeDevDistCleaner.java
Show resolved
Hide resolved
loader/src/test/java/net/neoforged/fml/common/asm/RuntimeDistCleanerTest.java
Show resolved
Hide resolved
|
🚀 This PR has been released as FancyModLoader version |
This supersedes and extends #228 to replace RuntimeDistCleaner entirely with a solution that does not involve ASM, uses the manifest file masking of neoforged/NeoFormRuntime#66 and neoforged/NeoGradle#257, and has no effects in prod:
ILaunchPluginService, which throws an exception when one attempts to load one of those classes with the same message asRuntimeDistCleanerwould have provided.RuntimeDistCleaneris removed entirely, as it is unnecessary.RuntimeDistCleanerTestis replaced with a short test in a userdev dev environment.