Provide better errors when game-layer mod files try to provide class processors #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lukebemish
suggested changes
Oct 5, 2025
| for (var provides : descriptor.provides()) { | ||
| if (provides.service().equals(ClassProcessorProvider.class.getName()) | ||
| || provides.service().equals(ClassProcessor.class.getName())) { | ||
| issues.add(ModLoadingIssue.error("fml.modloadingissue.classprocessor_in_game_content").withAffectedModFile(modFile)); |
Contributor
There was a problem hiding this comment.
Don't we need to do this for all the other FML services too? Anything that requires LIBRARY or higher should cause an error here if it's coming from a mod jar.
Contributor
Author
There was a problem hiding this comment.
Early services should mark the discovered jar forcefully as a discovered meaning it should not participate in normal discovery anymore. (Due to being that hacky pre-discovery that is built outside of the locator system).
p.s.: If there isn't a test for this, we should add one.
Contributor
There was a problem hiding this comment.
That's not true for IModLanguageLoader, only for the ones in EarlyDiscoveryServices.SERVICES.
neoforged-automation
bot
added
the
needs rebase
|
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example error:
ERROR: Mod file .* is trying to provide a ClassProcessor service. Mods and game libraries cannot provide such services, only libraries can.
This moves the parallel computation of module descriptors as an explicit step before we build the game layer, since we now access these descriptors to check for services. (This is also done in parallel in the jar finder, which is later).