Skip to content

Strip JST-Injected Enum Extensions#412

Open
lukebemish wants to merge 6 commits into
neoforged:mainfrom
lukebemish:strip-jst-injected-enum-entries
Open

Strip JST-Injected Enum Extensions#412
lukebemish wants to merge 6 commits into
neoforged:mainfrom
lukebemish:strip-jst-injected-enum-entries

Conversation

@lukebemish
Copy link
Copy Markdown
Contributor

@lukebemish lukebemish commented Apr 3, 2026

Companion to neoforged/JavaSourceTransformer#62. To ensure that the same ordering is used between production and development, no matter if enum entries come from JST or are added at runtime (or a combination, with duplicates), all JST-added enum entries are stripped at runtime, before runtime-added entries are added. The corresponding JST PR allows configuration of an annotation to add to injected entries -- in this case, @ExtensionEnumEntry.

It should be possible to backport this.

@lukebemish lukebemish marked this pull request as ready for review April 3, 2026 21:20
@neoforged-pr-publishing
Copy link
Copy Markdown

neoforged-pr-publishing Bot commented Apr 3, 2026

  • Publish PR to GitHub Packages

Last commit published: 0080d08feeb79d38654301f22cd13760605cdb04 - version: 11.0.18-pr-412-strip-jst-injected-enum-entries

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name = "Maven for PR #412" // https://github.com/neoforged/FancyModLoader/pull/412
        url = uri("https://prmaven.neoforged.net/FancyModLoader/pr412")
        content {
            includeModule("net.neoforged.fancymodloader", "earlydisplay")
            includeModule("net.neoforged.fancymodloader", "junit-fml")
            includeModule("net.neoforged.fancymodloader", "loader")
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant