Skip to content

Conversation

@shartte
Copy link
Contributor

@shartte shartte commented Apr 26, 2025

Exposes a Problem Reporting API to plugins, and uses that API to report issues with access transformers.

A new CLI option can be used to get all reported problems in a JSON format.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 26, 2025

  • Publish PR to GitHub Packages

Last commit published: 10fa1ef999adccc9c9d8b45b0506c2ddd6d59b70.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #50' // https://github.com/neoforged/JavaSourceTransformer/pull/50
        url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr50'
        content {
            includeModule('net.neoforged.jst', 'jst-api')
            includeModule('net.neoforged.jst', 'jst-cli')
            includeModule('net.neoforged.jst', 'jst-cli-bundle')
        }
    }
}

@neoforged-automation
Copy link
Contributor

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Apr 26, 2025
@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Apr 27, 2025
@shartte shartte marked this pull request as ready for review April 27, 2025 15:34
@shartte shartte changed the title Problem reporting prototype Add Problem Reporting API and provide Access Transformer Errors in a Machine Readable Format Apr 27, 2025
Copy link
Member

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not have any of the errors in ApplyATsVisitor (that use this method) changed to the problems system.

Comment on lines +68 to +71
if (e instanceof RuntimeException re) {
throw re;
}
throw new RuntimeException(e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this with a sneaky generic throw, not sure if we have a helper for that in JST.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a friend of that hack tbh. Is there a significant issue with this wrapping?

@shartte shartte merged commit b58cda4 into neoforged:main May 2, 2025
2 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as JavaSourceTransformer version 1.0.72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants