Ensure parent directories are created before writing files in FolderFileSink #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
covers1624
reviewed
Aug 24, 2025
|
🚀 This PR has been released as JavaSourceTransformer version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a folder sink is used it only creates the root directory, but not any intermediary directories of files.
An example when this crash occurs is when a Zip is used as input format, while a folder is output.
Because the zip does not have directory entries it will not trigger putDirectory properly, causing a crash when it processes the first file in a directory (generally META-INF/METADATA.MF).