Skip to content

Support reporting of problems from NFRT via the Gradle Problems API if supported (8.13+)#248

Merged
shartte merged 6 commits into
mainfrom
problems
May 7, 2025
Merged

Support reporting of problems from NFRT via the Gradle Problems API if supported (8.13+)#248
shartte merged 6 commits into
mainfrom
problems

Conversation

@shartte
Copy link
Copy Markdown
Collaborator

@shartte shartte commented Apr 27, 2025

This makes use of the problem report added to JST/NFRT to enable access transform validation for just the users AT, and also as a bonus, reports the AT validation issues to the problems API (this only manifests in the HTML problem report at the moment).

Fixes #236.

@neoforged-pr-publishing
Copy link
Copy Markdown

neoforged-pr-publishing Bot commented Apr 27, 2025

  • Publish PR to GitHub Packages

Last commit published: 715650ac1d7e1c3499af22120de31659ba904dc7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #248' // https://github.com/neoforged/ModDevGradle/pull/248
        url 'https://prmaven.neoforged.net/ModDevGradle/pr248'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

@neoforged-automation neoforged-automation Bot added the needs rebase This Pull Request needs to be rebased before being merged label May 2, 2025
@neoforged-automation
Copy link
Copy Markdown

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

shartte added 2 commits May 4, 2025 23:28
# Conflicts:
#	src/main/java/net/neoforged/nfrtgradle/NeoFormRuntimeExtension.java
@neoforged-automation neoforged-automation Bot removed the needs rebase This Pull Request needs to be rebased before being merged label May 4, 2025
@Technici4n
Copy link
Copy Markdown
Member

Confirmed to fix #236. If you are happy with my changes just merge it @shartte.

@shartte shartte merged commit d84205d into main May 7, 2025
6 checks passed
@shartte shartte deleted the problems branch May 7, 2025 19:08
@neoforged-releases
Copy link
Copy Markdown

🚀 This PR has been released as ModDevGradle version 2.0.88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validateAccessTransformers causes issues on 1.20.1 and 1.20.4

2 participants