Fix early client lifecyle events and introduce ClientResourceLoadFinishedEvent. The NeoForge event bus also starts earlier now. #2104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2096, since the event will be dropped while the NeoForge event bus has not yet been started.
The fix for that is starting the event bus earlier, which introduces the problem of tick events being fired before the game has finished loading (the demarcation for this in Vanilla is the completion of the first resource load).
To then fix that problem, the tick events are now only emitted if Vanilla considers the game to be fully loaded.
Additionally, at that precise location we introduce a new event that allows mods to react to the first successful (or any subsequent successful) resource loads (
ClientResourceLoadFinishedEvent
).