Skip to content

[1.21.4] Make LootItemConditionalFunction#simpleBuilder and Loot Functions without builders Constructors public #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 1.21.4
Choose a base branch
from
Open

[1.21.4] Make LootItemConditionalFunction#simpleBuilder and Loot Functions without builders Constructors public #2130

wants to merge 2 commits into from

Conversation

JT122406
Copy link
Contributor

Backport of #2119 and #2068

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Apr 12, 2025
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

sciwhiz12
sciwhiz12 requested changes Apr 14, 2025
View reviewed changes
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor formatting change, looks fine to me.

@sciwhiz12 sciwhiz12 added enhancement New (or improvement to existing) feature or request backport Backport to an older version from a newer version labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sciwhiz12 sciwhiz12 sciwhiz12 approved these changes

Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4 backport Backport to an older version from a newer version enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JT122406 @sciwhiz12