[26.1][26w14a] April Fools snapshot#3136
Open
Lonmo0208 wants to merge 48 commits into
Open
Conversation
|
|
@Lonmo0208, this PR introduces breaking changes. Compatibility checks
|
Lonmo0208
changed the title
Author
|
So, is there any chance that this merge could create (or lead to) a new branch for 26w14a? |
Contributor
|
@Lonmo0208, this pull request has conflicts, please resolve them for this PR to move forward. |
Contributor
|
@Lonmo0208, this pull request has conflicts, please resolve them for this PR to move forward. |
Contributor
|
@Lonmo0208, this pull request has conflicts, please resolve them for this PR to move forward. |
Author
٩(•̤̀ᵕ•̤́๑)ᵒᵏᵎᵎᵎᵎ |
…oforge.mods.toml to start with 26.1. Add copyMinecraftVersion = 26.1... Change the version in minecraft.neoforge.mods.toml to start with 26.1, so that some mods available for the 26.1 release version can be directly compatible.
Author
Hi! Hope you’re doing well. Wanted to touch base about this PR. Is there anything I can do to help move it forward? I’ll be offline starting May 23rd (Beijing time) for 10 days, so it’d be great to finalize things before then. Thanks! 😊 |
Author
|
No one is responding... 😢 |
Author
|
Hello!？ |
Author
|
Hello!？Hello!？ |
…ComponentHolderResource#with (neoforged#3187)
Author
|
？？？hi？ |
sciwhiz12
requested changes
May 26, 2026
Member
sciwhiz12
left a comment
sciwhiz12
left a comment
There was a problem hiding this comment.
I apologize for the delay. I have been quite busy the past few weeks, and could not review this earlier.
This is going to take a while to review, because I don't exactly know all the necessary changes to make this branch ready for publishing, and because of the many patch changes. This is the first part of my review, and I'll make another review when I have more time to sink into this PR.
In general, we'll likely need to follow the same logic changes in the 25w14craftmine branch to the versioning and Gradle buildscript logic. See 26.1.x...25w14craftmine.
We will need to either amend the release.yml workflow in this branch and our default branch (26.1.x) or rename the branch accordingly to fit the regex that detects April Fools snapshots. The current regex will not match this branch, due to the added -herdcraft disambiguating suffix.
NeoForge/.github/workflows/release.yml
Line 10 in 71666ae
…ner item should be consumed (neoforged#3189)
Author
|
Request for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my port of the 26w14a April Fools snapshot.
I'm not sure if my changes follow the proper conventions — after all, I'm not a professional programmer.
But I thought it might be fun to be able to play with 26.1.x mods on the April Fools version.
Maybe it could also inspire more mod creators and modpack authors to make even more interesting mods.
I've done some basic playtesting so far and haven't found any bugs.
If there are any, I hope the community can help maintain this together. Thank you!
P.S. This is a version specifically for the April Fools snapshot, and it will need a separate branch (if you're willing and find it interesting — similar to last year's 25w14craftmine).
CN：
这是我移植的 26w14a 愚人节快照版本。
我不确定我的更改是否符合规范，毕竟我不是专业编程人员。
但我觉得，能够在愚人节版本上玩到 26.1.x 模组，或许会很有趣？
也许这也能激发更多模组创作者、整合包创作者写出更有趣的模组。
我已经进行了基本的游玩测试，目前没有发现任何 Bug。
如果有，我希望社区的大家可以一起来维护。谢谢！
P.S. 这是一个针对愚人节快照的版本，需要重新开一个分支（如果你们愿意且觉得有趣的话，就像去年的 25w14craftmine 那样）