Use ItemStack sensitive getCraftingRemainder in vanilla code#3157
Merged
Shadows-of-Fire merged 3 commits intoMay 16, 2026
Conversation
|
sciwhiz12
requested changes
May 12, 2026
Member
sciwhiz12
left a comment
sciwhiz12
left a comment
There was a problem hiding this comment.
Needs one change. Otherwise, looks fine.
sciwhiz12
added
bug
Sirttas
force-pushed
the
fix-get-crafting-result
branch
3 times, most recently
from
c068fec to
7988b99
Compare
Sirttas
force-pushed
the
fix-get-crafting-result
branch
from
7988b99 to
137aba3
Compare
ApexModder
reviewed
May 14, 2026
ApexModder
reviewed
May 14, 2026
Member
ApexModder
left a comment
ApexModder
left a comment
There was a problem hiding this comment.
Everything looks fine to me aside from the change in Ingredient.java.patch
Sirttas
force-pushed
the
fix-get-crafting-result
branch
from
8456564 to
174393f
Compare
XFactHD
approved these changes
May 14, 2026
sciwhiz12
approved these changes
May 14, 2026
|
🚀 This PR has been released as NeoForge version |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeoForge allows mods to override getCraftingRemainder per ItemStack instance (rather than just per Item). Vanilla code was calling the Item-level method directly, bypassing any stack-sensitive overrides registered by mods.