Fix lastHurt tracking post-reduction damage#3203
Open
Shadows-of-Fire wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #3101,
LivingEntity#lastHurtwas trackingDamageContainer#getInflictedDamage, which is a post-reduction damage value. The way thatlastHurtis actually used, however, requires tracking pre-reduction values, otherwise having damage reduction can incur i-frame ignoring attack cycles.The side effect of this, however, is that if
LivingDamageEvent.Preelects to increase the damage taken, it will not be reflected inlastHurt. I suppose users should preferLivingIncomingDamageEventfor that, however.Closes #3201