Skip to content

Remove use of getProject from Patch failure path#294

Closed
octylFractal wants to merge 1 commit into
neoforged:NG_7.1from
octylFractal:fix/cc-fail-on-fail
Closed

Remove use of getProject from Patch failure path#294
octylFractal wants to merge 1 commit into
neoforged:NG_7.1from
octylFractal:fix/cc-fail-on-fail

Conversation

@octylFractal
Copy link
Copy Markdown

This use seems entirely unnecessary given that the task also has a logger. It causes a configuration cache error when the task fails, instead of indicating a proper failure.

@neoforged-pr-publishing
Copy link
Copy Markdown

  • Publish PR to GitHub Packages

@marchermans marchermans enabled auto-merge (squash) December 10, 2025 07:03
marchermans added a commit that referenced this pull request Dec 10, 2025
…ng the finals before.

Supersedes: #294
Closes: #294

Co-authored-by: @octylFractal
marchermans added a commit that referenced this pull request Dec 10, 2025
…ng the finals before.

Supersedes: #294
Closes: #294

Co-authored-by: @octylFractal
auto-merge was automatically disabled December 10, 2025 12:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants