Skip to content

🚸 Normalized urls for yahoo search engine to remove redirects #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 5, 2025

Conversation

ROHANREDDYGADE
Copy link
Contributor

What does this PR do?
This PR updates the way Yahoo URLs are handled. Instead of getting redirected Yahoo URLs, we now extract and use the normal, direct URLs.

Why is this change important?
Previously, URLs from Yahoo search results were in a redirected form. This change ensures that users receive the direct URLs instead of being redirected, improving accuracy and user experience.

How to test this PR locally?

  1. Clone the repository and check out this branch.

  2. Run the program and perform a search that would previously return a redirected Yahoo URL.

  3. Verify that the URLs returned are now the normal, direct URLs.

Previously how it works :-
Yahoo redirected urls

Now :-
Clean results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Websurfx! ❤️!
Say hello by joining the conversation in our Discord

@neon-mmd neon-mmd changed the title Normalized Urls for Yahoo Search Engine No more redirect Urls 🚸 Normalized urls for yahoo search engine to remove redirects Apr 27, 2025
neon-mmd
neon-mmd previously approved these changes Apr 27, 2025
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

Thanks ❤️ for working on such a wonderful PR. We really appreciate it. Good job!! Keep it up!! 👍 . Since everything looks good. We will merge this PR as soon as possible 🙂 .

Note

I have left a short comment/concern on a code change. So if you could resolve then it would be great. Otherwise the PR is great. I really appreciate the cool work. 👍

@ROHANREDDYGADE
Copy link
Contributor Author

✅ Replaced url::percent_encoding with a manual percent decoder to fix build errors.
All Yahoo engine URLs are now decoded manually using only the Rust standard library.

@ROHANREDDYGADE
Copy link
Contributor Author

The previous merge check was stuck on “Checking for the ability to merge automatically…” for over a day. To resolve this, I pushed a dummy commit to retrigger the CI workflows. I’ve verified that both build and test steps now run and pass successfully. ✅

Let me know if any further changes are needed!

jfvillablanca
jfvillablanca previously approved these changes Apr 30, 2025
@neon-mmd
Copy link
Owner

neon-mmd commented May 4, 2025

@ROHANREDDYGADE
Sorry for the ping.
It has been nearly week, any updates on this PR? 😅

@ROHANREDDYGADE
Copy link
Contributor Author

resolved those clippy format issues

@spencerjibz
Copy link
Collaborator

LGTM

@spencerjibz spencerjibz merged commit c1f52d1 into neon-mmd:rolling May 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants