Skip to content

http-utils: generate heap profiles with jemalloc_pprof #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

erikgrinaker
Copy link
Contributor

Problem

The code to generate symbolized pprof heap profiles and flamegraph SVGs has been upstreamed to the jemalloc_pprof crate:

Summary of changes

Use jemalloc_pprof to generate symbolized pprof heap profiles and flamegraph SVGs.

This reintroduces a bunch of internal jemalloc stack frames that we'd previously strip, e.g. each stack now always ends with prof_backtrace_impl (where jemalloc takes a stack trace for heap profiling), but that seems ok.

@erikgrinaker erikgrinaker requested review from a team and arpad-m and removed request for a team March 4, 2025 09:35
Copy link

github-actions bot commented Mar 4, 2025

7814 tests run: 7436 passed, 0 failed, 378 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.9% (8677 of 26376 functions)
  • lines: 48.8% (73899 of 151292 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
91bf6c8 at 2025-03-04T12:22:46.215Z :recycle:

@erikgrinaker erikgrinaker requested review from VladLazar and removed request for arpad-m March 4, 2025 11:38
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upstreaming!

@erikgrinaker erikgrinaker enabled auto-merge March 4, 2025 11:49
@erikgrinaker erikgrinaker added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit a2902e7 Mar 4, 2025
101 checks passed
@erikgrinaker erikgrinaker deleted the erik/jemalloc-pprof-upstream branch March 4, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants