Open
Conversation
Collaborator
Author
|
Currently on top of 102-* (so this PR has just one commit for now) |
Collaborator
Author
|
My commit message is quite extensive and explains it a bit. Although fixed, it broke down once more, but then ran threw solid several times, so I hope it was just a hiccup. I don't understand why the error previously kept coming repetitively. Regarding the race condition: Let's say 3 tasks try to click the cookies away, 1 succeeds, 2 fail. So there should be only two errors. But from what I saw previously, once the error was triggered it came again and again and again... This being said: I don't fully trust my current solution :) |
…present handlePuppetReady() is called very often and in parallel Removing the sleep(1000) the condition (can I click?) and action (I do click) are closer to each other and we have less chance for a race condition.
hoelger
force-pushed
the
180-cookie-errors-in-the-background
branch
from
6793411 to
6c42f4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.