-
-
Notifications
You must be signed in to change notification settings - Fork 38
FEATURE: Implement component for displaying Favicons in frontend #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crydotsnake
wants to merge
6
commits into
neos:8.4
Choose a base branch
from
crydotsnake:feature/implement-favicons
base: 8.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5731436
FEATURE: Implement component for displaying Favicons in frontend
d636c48
TASK: remove unneeded icons
2cc4725
TASK: simplify rendering
1b5a077
TASK: adjust site.webmanifest
bdfd317
TASK: make packageKey overwritable in favicon component
55cdfb1
TASK: adjust favicons
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| prototype(Neos.Demo:Presentation.Favicons) < prototype(Neos.Fusion:Component) { | ||
|
|
||
| renderer = afx` | ||
| <link rel="apple-touch-icon" sizes="180x180" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/apple-touch-icon.png')} /> | ||
| <link rel="icon" type="image/png" sizes="16x16" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/favicon-16x16.png')} /> | ||
| <link rel="icon" type="image/png" sizes="70x70" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/mstile-70x70.png')} /> | ||
| <link rel="icon" type="image/png" sizes="192x192" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/android-chrome-192x192.png')} /> | ||
| <link rel="manifest" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/site.webmanifest')} /> | ||
| <link rel="mask-icon" href={StaticResource.uri('Neos.Demo', 'Public/Assets/Favicons/safari-pinned-tab.svg')} color="#5bbad5" /> | ||
| <meta name="msapplication-TileColor" content="#2d89ef" /> | ||
| <meta name="theme-color" content="#ffffff" /> | ||
| ` | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <browserconfig> | ||
| <msapplication> | ||
| <tile> | ||
| <square150x150logo src="/mstile-150x150.png"/> | ||
| <TileColor>#00adee</TileColor> | ||
| </tile> | ||
| </msapplication> | ||
| </browserconfig> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "name": "Neos", | ||
| "short_name": "Neos", | ||
| "prefer_related_applications": true, | ||
| "icons": [ | ||
| { | ||
| "src": "/android-chrome-192x192.png", | ||
| "sizes": "192x192", | ||
| "type": "image/png" | ||
| }, | ||
| { | ||
| "src": "/apple-touch-icon.png", | ||
| "sizes": "180x180", | ||
| "type": "image/png" | ||
| }, | ||
| { | ||
| "src": "/favicon-16x16.png", | ||
| "sizes": "16x16", | ||
| "type": "image/png" | ||
| }, | ||
| { | ||
| "src": "/mstile-70x70.png", | ||
| "sizes": "70x70", | ||
| "type": "image/png" | ||
| } | ||
| ], | ||
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.