TASK: Uniquify exception codes in Abstract(Template)View #3413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception codes are supposed to be unique, so this makes sure those four places get a code of their own.
markusguenther
approved these changes
Jan 15, 2025
Member
markusguenther
left a comment
markusguenther
left a comment
There was a problem hiding this comment.
That definitely makes sense.
kdambekalns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception codes are supposed to be unique, so this makes sure those places get a code of their own.
Upgrade instructions
If you rely on that exception code (
1359625876) for whatever reason, consider taking the new codes into account, too:1359625877135962587813596258791359625880135962588113596258821359625883Review instructions
You could check if any of the new codes is in use already, in turn… 😬
Checklist
FEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions