TASK: Cosmetic followup for #3443 #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
we don't make a distinction inside the service from development, testing or production
kitsunet
approved these changes
Feb 14, 2025
Member
kitsunet
left a comment
kitsunet
left a comment
There was a problem hiding this comment.
Fine by me, see one comment though
kdambekalns
reviewed
Feb 14, 2025
kdambekalns
requested changes
Feb 14, 2025
Member
kdambekalns
left a comment
kdambekalns
left a comment
There was a problem hiding this comment.
Please check the failure of aggregateRootAssignmentsInHierarchiesAreCorrect
mhsdesign
force-pushed
the
task/followup-3443-code-style
branch
from
d2a5c47 to
d26d02f
Compare
6 tasks
Member
Author
the one commit with the removed sorting seemed to cause that, even if i could not reproduce it locally and thus dont know the WHY - anyway that change was too critical anyway for a cleanup pr like that and has been extracted to #3448 so this is now finalised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the review of #3443 I couldn't help to do a little cleaning myself :D 🧹
Checklist
The PR is created against the lowest maintained branchFEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions