DRAFT: Raise PhpStan to level 8 #3468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
April 4, 2025 22:42
added 14 commits
April 12, 2025 12:19
mhsdesign
reviewed
Apr 18, 2025
| */ | ||
| protected $environmentConfiguration; | ||
|
|
||
| /** | ||
| * Constructs this backend | ||
| * | ||
| * @param EnvironmentConfiguration $environmentConfiguration | ||
| * @param array $options Configuration options - depends on the actual backend | ||
| * @param ?EnvironmentConfiguration $environmentConfiguration @todo is this ever null and does that even make sense? |
There was a problem hiding this comment.
fyi solved this in an followup pr #3470
> Cannot declare class Neos\Flow\Aop\Exception, because the name is already in use `$exception` in line 64 with the doc type changed to `?\Exception` from `\Exception` is at fault. It seems the expansion from `?\Exception` behaves differently than `\Exception|null` and thus another `class_exist` checks leads to multiple autoloading.
|
Closed in favor of #3474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade instructions
Adjust all dependent code to potential type changes
Review instructions
Please check whether all
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions