Skip to content

DRAFT: Raise PhpStan to level 8 #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 47 commits into from
Closed

Conversation

nezaniel
Copy link
Member

@nezaniel nezaniel commented Apr 4, 2025

Upgrade instructions

Adjust all dependent code to potential type changes

Review instructions

Please check whether all

  • types have been applied correctly
  • all fallback values make sense

Checklist

  • Code follows the PSR-12 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@nezaniel nezaniel marked this pull request as draft April 4, 2025 19:58
@github-actions github-actions bot added the 10.0 label Apr 4, 2025
*/
protected $environmentConfiguration;

/**
* Constructs this backend
*
* @param EnvironmentConfiguration $environmentConfiguration
* @param array $options Configuration options - depends on the actual backend
* @param ?EnvironmentConfiguration $environmentConfiguration @todo is this ever null and does that even make sense?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi solved this in an followup pr #3470

Bernhard Schmitt and others added 5 commits May 2, 2025 16:29
> Cannot declare class Neos\Flow\Aop\Exception, because the name is already in use

`$exception` in line 64 with the doc type changed to `?\Exception` from `\Exception` is at fault. It seems the expansion from `?\Exception` behaves differently than `\Exception|null` and thus another `class_exist` checks leads to multiple autoloading.
@nezaniel
Copy link
Member Author

nezaniel commented May 3, 2025

Closed in favor of #3474

@nezaniel nezaniel closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants