DRAFT: Raise PhpStan to level 8 - Part 2 #3518
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
2 times, most recently
from
e4a16fd to
d8b7541
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
13 times, most recently
from
569883c to
f422f3c
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
f422f3c to
587ecda
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
2 times, most recently
from
886f119 to
d9f48cc
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
4 times, most recently
from
1817430 to
58de00d
Compare
…n context and reduce breakiness
…ty context and remove breaking changes Some return type Annotations in the ObjectManagerInterface are adjusted to match the reality already to prevent false errors beeing reported by PhpStan
…ceManagement context and remove breaking changes The return type of UnicodeFunctions::pathinfo was amended to reflect the fact that the key extension will be missing when no extension is present as is stated by the php reference here. > https://www.php.net/manual/en/function.pathinfo.php > Note: If the path does not have an extension, no extension element will be returned (see second example below).
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
dbcb441 to
219c2fc
Compare
The key 'uri' may be missing on stream_get_metadata when streams are created for a socket connection. This is no issue that is relevant for the flow resource management as far as i am aware.
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
086f2a5 to
a353a69
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
3 times, most recently
from
6bb0506 to
6e68c11
Compare
…tion context and remove breaking changes
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
6e68c11 to
31e5dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise PhpStan to level 8 for:
This is a follow up for: #3515
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions