Skip to content

Conversation

@mhsdesign
Copy link
Member

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the Task label Dec 7, 2025
@mhsdesign mhsdesign marked this pull request as draft December 7, 2025 08:52
@github-actions github-actions bot added the 8.3 label Dec 7, 2025
this is deprecated https://wiki.php.net/rfc/warnings-php-8-5

> unexpected NAN value was coerced to string
@dlubitz
Copy link
Contributor

dlubitz commented Dec 7, 2025

You're a bit late to the party.
#3527

@mhsdesign
Copy link
Member Author

haha lol i see ... but why only 8.4 but yes nevermind lets close this then

@mhsdesign mhsdesign closed this Dec 7, 2025
@dlubitz
Copy link
Contributor

dlubitz commented Dec 7, 2025

Because 8.3 is security fixes only.

@dlubitz
Copy link
Contributor

dlubitz commented Dec 7, 2025

But wait... Is it really? We should discuss the state of 8.3 with the release of 8.4. Actually we released it as LTS.

@kdambekalns kdambekalns reopened this Dec 8, 2025
@kdambekalns kdambekalns closed this Dec 8, 2025
@kdambekalns kdambekalns reopened this Dec 8, 2025
@kdambekalns
Copy link
Member

Ok, the other PR #3527 was merged into 8.4 and cherry-pciked into 8.3, so we are done.

@kdambekalns kdambekalns closed this Dec 8, 2025
@kdambekalns kdambekalns deleted the feature/php-85-compatibility branch December 8, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants