BUGFIX: Prevent sharing splitString between node routings #5572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
approved these changes
Jun 12, 2025
Member
bwaidelich
left a comment
bwaidelich
left a comment
There was a problem hiding this comment.
Makes sense to me – this was a proper foot gun..
I think Flow should be more picky about this => neos/flow-development-collection#3485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that each route has its own handler instance and prevents accidental sharing of instance properties. An optimal solution wouldn't need the
splitStringas instance variable anymore, but this would require a change in Flow.Resolves: #5571