BUGFIX: Comments must not be null when handled to string functions#5698
Open
daniellienert wants to merge 4 commits intoneos:9.0from
Open
BUGFIX: Comments must not be null when handled to string functions#5698daniellienert wants to merge 4 commits intoneos:9.0from
daniellienert wants to merge 4 commits intoneos:9.0from
Conversation
dlubitz
reviewed
Dec 12, 2025
Contributor
dlubitz
left a comment
dlubitz
left a comment
There was a problem hiding this comment.
Thank you @daniellienert for the PR. I left some comments.
Neos.ContentRepositoryRegistry/Classes/Command/NodeMigrationCommandController.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepositoryRegistry/Classes/Command/NodeMigrationCommandController.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.NodeMigration/src/Command/MigrationConfiguration.php
Show resolved
Hide resolved
Adjust for review suggestions
dlubitz
approved these changes
Jan 23, 2026
mhsdesign
reviewed
Jan 23, 2026
Neos.ContentRepository.NodeMigration/src/NodeMigrationService.php
Outdated
Show resolved
Hide resolved
mhsdesign
reviewed
Jan 23, 2026
Neos.ContentRepository.NodeMigration/src/NodeMigrationService.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resloves: #5697