Conversation
… and crashes if object is not StringAble With neos/neos-ui#3723 and neos/neos-ui#3723 the `NodePropertyConverterService` returns `\JsonSerializable` objects directly in the expectation that they are serialized directly. This is also true for the usages within the Neos Ui. But this legacy endpoint here in Neos doesnt do it. And throws "Object of class Sitegeist\Archaeopteryx\Link could not be converted to string" on some occasions whenever the endoint is used. Funnely the Neos Ui really does not care about the node properties rendered here via fluid in html so we could also return "nudelsuppe" here. Its just important that it not crashes. https://github.com/neos/neos-development-collection/blob/1aeef6c02142b41e4626ea32434f06cd0f84e9bd/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html#L30-L35 In the future we should have this whole thing killed :D
Member
Author
|
See also report in slack https://neos-project.slack.com/archives/C04PYL8H3/p1765379093714569 This fix is especially important for 9.1 as well have a native non stringalbe but jsonserializeable link value object: #5682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With neos/neos-ui#3723 and neos/neos-ui#3723 the
NodePropertyConverterServicereturns\JsonSerializableobjects directly in the expectation that they are serialized directly. This is also true for the usages within the Neos Ui.But this legacy endpoint here in Neos doesnt do it. And throws
"Object of class Sitegeist\Archaeopteryx\Link could not be converted to string"
on some occasions whenever the endoint is used. Funnely the Neos Ui really does not care about the node properties rendered here via fluid in html so we could also return "nudelsuppe" here. Its just important that it not crashes.
neos-development-collection/Neos.Neos/Resources/Private/Templates/Service/Nodes/Show.html
Lines 30 to 35 in 1aeef6c
In the future we should have this whole thing killed :D
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions