Skip to content

BUGFIX: Ensure Node->timestamps use UTC format consistently and not date_default_timezone_get() base on the system#5716

Open
mhsdesign wants to merge 1 commit intoneos:9.0from
mhsdesign:bugfix/ensure-TimeStamps-use-UTC-format-and-not-date_default_timezone_get
Open

BUGFIX: Ensure Node->timestamps use UTC format consistently and not date_default_timezone_get() base on the system#5716
mhsdesign wants to merge 1 commit intoneos:9.0from
mhsdesign:bugfix/ensure-TimeStamps-use-UTC-format-and-not-date_default_timezone_get

Conversation

@mhsdesign
Copy link
Member

In the database we dont persist the timezone but only the date. And dbal seems to automatically store them in UTC which makes sense.

During deserializing we need to ensure that we use always UTC too and never ask the system for its fallback as this is irrelevant.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

… `date_default_timezone_get()` base on the system

In the database we dont persist the timezone but only the date. And dbal seems to automatically store them in UTC which makes sense.

During deserializing we need to ensure that we use always `UTC` too and never ask the system for its fallback as this is irrelevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant