Skip to content

TASK: fix errors in CONTRIBUTING.md#5720

Open
skurfuerst wants to merge 1 commit into9.0from
bugfix/fix-errors-for-contributing
Open

TASK: fix errors in CONTRIBUTING.md#5720
skurfuerst wants to merge 1 commit into9.0from
bugfix/fix-errors-for-contributing

Conversation

@skurfuerst
Copy link
Member

I recently tried the steps in CONTRIBUTING.md, and found a few bugs :)

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

I prefer not cd too much and use our test:behat-cli composer script which makes behat sane. Why sane because otherwise behat uses the ultra verbose logging format and not the dots and behat wont fail if a step definition does not exist which it should:) Wdyt?

composer test:behavioral

# to run all tests of Neos.ContentRepository.BehavioralTests:
cd Neos.ContentRepository.BehavioralTests/Tests/Behavior
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd Neos.ContentRepository.BehavioralTests/Tests/Behavior
composer test:behat-cli -- -c Neos.ContentRepository.BehavioralTests/Tests/Behavior/behat.yml.dist

Comment on lines +205 to +206
# to run only a single test:
../../../../../bin/behat -c behat.yml.dist Features/01-RootNodeCreation/01-CreateRootNodeAggregateWithNode_ConstraintChecks.feature:72
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# to run only a single test:
../../../../../bin/behat -c behat.yml.dist Features/01-RootNodeCreation/01-CreateRootNodeAggregateWithNode_ConstraintChecks.feature:72
# to run only a single test (optionally with line number to specify the scenario):
composer test:behat-cli -- -c Neos.ContentRepository.BehavioralTests/Tests/Behavior/behat.yml.dist Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/01-RootNodeCreation/01-CreateRootNodeAggregateWithNode_ConstraintChecks.feature:72

Comment on lines +208 to +214
cd ../../../


# to run all tests of Neos.Neos:
cd Neos.Neos/Tests/Behavior
../../../../../bin/behat -c behat.yml.dist
cd ../../../
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd ../../../
# to run all tests of Neos.Neos:
cd Neos.Neos/Tests/Behavior
../../../../../bin/behat -c behat.yml.dist
cd ../../../
# to run all tests of Neos.Neos:
composer run test:behat-cli -- -c Neos.Neos/Tests/Behavior/behat.yml.dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants