TASK: New link editor final final final polish #4037
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mptyValue` with `DialogWithValue` And also get rid of hacky details like `initialLinkTypePreview?: () => React.ReactNode` Initially the split into two components and the duplication of the tab rendering and the like was necessary as the initial link type allowed upon `convertLinkToModel` to invoke a react hook. And react hooks can not be used conditionally. With this removal of first class async tabs (a3132ca) we can also simplify the code in the Dialog.
…de to close support
…rips off popover positioning It seems the transformation is technically part of the spec as per this discussion: w3c/csswg-drafts#8584 But not implemented in any browser. The transformation is currently not taken into account and the popover is positioned as if the dialog is not transformed. To fix that we now resort to a simple flex centering. TODO: Due to flex and no longer the use of `left: 50%;` the width of the dialog is not sanely restricted to 50vw but always as wide as possible making text dialogs pretty wide.
in chrome we use the new anchor api and otherwise calculate the position taking the button height 40px into account and using flexbox row-reverse around to be right to the button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny followup attempting to polish the new link editor to absolute shininess ;)
Todo:
What I did
How I did it
How to verify it