Skip to content

TASK: New 9.1 Drag and drop: Let server feedback determine node removal from the dom #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mhsdesign wants to merge 1 commit into
base: 9.1
Choose a base branch
from
Draft

TASK: New 9.1 Drag and drop: Let server feedback determine node removal from the dom #4103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/neos-ui-guest-frame/src/InlineUI/DragAndDropUi/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {FusionPath, InsertPosition, Node, NodeContextPath} from '@neos-project/n
import {
closestContextPathInGuestFrame,
closestNodeInGuestFrame,
findNodeInGuestFrame,
getGuestFrameDocument
// @ts-ignore
} from '@neos-project/neos-ui-guest-frame/src/dom';
Expand Down Expand Up @@ -225,13 +224,6 @@ const DragAndDropUi: React.FC<DragAndDropUiProps & InjectedDragAndDropUiProps> =
targetNodeContextPath,
insertPosition
);

// Remove the original node from the DOM
// TODO: Verify that the move was successful before removing the node
const movedNode = findNodeInGuestFrame(draggedNodeContextPath, draggedNodeFusionPath);
if (movedNode) {
movedNode.remove();
}
}, []);

const handleDragEnd = useCallback(() => {
Expand Down
Loading