BUGFIX: Remove extra <ul> from react ui component SelectBox - #4141
Open
minedesign-jl wants to merge 5 commits into
Open
BUGFIX: Remove extra <ul> from react ui component SelectBox#4141minedesign-jl wants to merge 5 commits into
minedesign-jl wants to merge 5 commits into
Conversation
added 5 commits
June 7, 2026 20:29
…rkup, groupHeader turned into <p> for improved ax (neos#3826)
Member
|
I would be more confident targeting 9.2 who knows what demons this can have^^ 8.3 is super stable now and soon to be handed of in security only. Wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3826
What I did and how
<ul>wrap<div>is direct child of<ul>How I did it
<ul>from SelectBox.js - it uses drowdown.contents which already returns a<ul><li>and options in own<ul>var(--spacing-Half)How to verify it
checking for proper list markup for the following dropdowns
checking that dropdown ui component still produces valid markup by checking user dropdown.