This repository was archived by the owner on Apr 13, 2026. It is now read-only.
fix: spawn PTY as login shell to load full PATH - #130
Merged
Conversation
sorrycc
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-lflag to start as login shell, ensuring~/.zprofileand other login profile files are sourcednode/npmwhen the app is launched from Finder/Dock instead of a terminalCloses #101
Test plan
echo $PATH— should include homebrew/nvm/volta pathswhich nodeandwhich npm— should resolve correctlynode --version— should match the version configured via nvm/volta