fix: UpdateRemotePlugins not finding specs on windows #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specs were being found with a normalized path, but being requested without normalization. We now normalize the path we responding to spec requests.
This should be a more consistent way of handling paths between both neovim and this plugin.
Path.resolve() also returns the absolute path, while os.path.normpath did not. We need to both normalize the path and convert it to standard posix style to fix the issue.
|
macOS failures are unrelated, see neovim/node-client@de7ecb4 |
jamessan
added a commit
that referenced
this pull request
Nov 3, 2024
Changes since 0.5.0: - 4813ce6 fix(tests): failing tests on python3.13 about stacktrace messages #578 - 9391eff docs: avoid deprecated $NVIM_LISTEN_ADDRESS env var #575 - 9fc77f0 fix(tests): remove reference to pytest-runner #573 - a855fa3 fix: deprecated alias of logger.warn #569 - cc45f5b fix(tests): broadcast test fails #570 - 4d65226 fix(ci): macOS CI fails with "Unrecognized archive format" - d6dc8cf fix: UpdateRemotePlugins not finding specs on Windows #565 - 9f3e010 Revert "fix: vim.eval('v:true') should return python bool" #562 - f9d839f fix(tests): "provider#python3#Prog" was removed upstream #563 - 5f989df refactor: remove the use of forward references #558 - c4197f1 fix(ci): failing readthedocs build #554 - da0970e ci: fix failing readthedocs build - 7a84048 fix(ci): failing readthedocs build #553 - e74a7f6 test: attaching via socket, tcp, stdio #544 - 17fbcbc fix: prevent closed pipe errors on closing asyncio transport resources - 7f60f72 refactor: improve typing - 3f5f532 refactor: separate asyncio Protocol from AsyncioEventLoop - 2059684 refactor: use async coroutine and add debugging statements - be5810b refactor: expose event loop as a property rather than a field - a1347ee refactor!: completely wipe out pyuv
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs were being found with a normalized path, but being requested without normalization. We now normalize the path we responding to spec requests.
fixes #564