Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UpdateRemotePlugins not finding specs on windows #565

Merged

Conversation

tanj
Copy link
Contributor

@tanj tanj commented Apr 13, 2024

Specs were being found with a normalized path, but being requested without normalization. We now normalize the path we responding to spec requests.

fixes #564

tanj added 3 commits April 13, 2024 09:31
Specs were being found with a normalized path, but being requested
without normalization. We now normalize the path we responding to spec
requests.
This should be a more consistent way of handling paths between both
neovim and this plugin.
Path.resolve() also returns the absolute path, while os.path.normpath
did not. We need to both normalize the path and convert it to standard
posix style to fix the issue.
Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinmk justinmk merged commit d6dc8cf into neovim:master Apr 14, 2024
13 of 19 checks passed
@justinmk
Copy link
Member

macOS failures are unrelated, see neovim/node-client@de7ecb4

@tanj tanj deleted the 564-update-remote-plugins-not-finding-specs branch April 14, 2024 17:25
jamessan added a commit that referenced this pull request Nov 3, 2024
Changes since 0.5.0:

- 4813ce6 fix(tests): failing tests on python3.13 about stacktrace messages #578
- 9391eff docs: avoid deprecated $NVIM_LISTEN_ADDRESS env var #575
- 9fc77f0 fix(tests): remove reference to pytest-runner #573
- a855fa3 fix: deprecated alias of logger.warn #569
- cc45f5b fix(tests): broadcast test fails #570
- 4d65226 fix(ci): macOS CI fails with "Unrecognized archive format"
- d6dc8cf fix: UpdateRemotePlugins not finding specs on Windows #565
- 9f3e010 Revert "fix: vim.eval('v:true') should return python bool" #562
- f9d839f fix(tests): "provider#python3#Prog" was removed upstream #563
- 5f989df refactor: remove the use of forward references #558
- c4197f1 fix(ci): failing readthedocs build #554
- da0970e ci: fix failing readthedocs build
- 7a84048 fix(ci): failing readthedocs build #553
- e74a7f6 test: attaching via socket, tcp, stdio #544
- 17fbcbc fix: prevent closed pipe errors on closing asyncio transport resources
- 7f60f72 refactor: improve typing
- 3f5f532 refactor: separate asyncio Protocol from AsyncioEventLoop
- 2059684 refactor: use async coroutine and add debugging statements
- be5810b refactor: expose event loop as a property rather than a field
- a1347ee refactor!: completely wipe out pyuv
@jamessan jamessan mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UpdateRemotePlugins not finding any specs
2 participants