Updated Alex Sherstinsky pull request with fixes to get it working with current Zoho API #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rept
commented
Oct 23, 2014
rept
commented
- Fixed error in build_attributes build_attributes refl_h => refl_a
- Removed InvoiceItem class since it doesn't exist (anymore) in Zoho, and replaced it with LineItem
- Fixed error in to_hash that forced any class into ZohoInvoice::Invoice, this now checks the class
- Fixed error (probably due to change by Zoho) in save of base object result.body => result.env.body
- Expanded the mapping after an object is saved to Zoho so all values that are returned in the response (result.env.body) are mapped back to the known attributes. This will lower the number of calls needed to the API. After you save an invoice, it will now automatically fill the invoice_number from Zoho (as well as other values).
- Changed the attributes of LineItem so they match the ones returned by Zoho. Used READ_ATTRIBUTES (similar as Alex Sherstinsky did).
- Updated Contact so it matches definition of Zoho, and used READ_ATTRIBUTES similar to other classes.
added 30 commits
March 18, 2014 21:10
- Removed InvoiceItem class since it doesn't exist (anymore) in Zoho, and replaced it with LineItem - Fixed error in to_hash that forced any class into ZohoInvoice::Invoice, this now checks the class - Fixed error (probably due to change by Zoho) in save of base object result.body => result.env.body - Expanded the mapping after an object is saved to Zoho so all values that are returned in the response (result.env.body) are mapped back to the known attributes. This will lower the number of calls needed to the API. After you save an invoice, it will now automatically fill the invoice_number from Zoho (as well as other values). - Changed the attributes of LineItem so they match the ones returned by Zoho. Used READ_ATTRIBUTES (similar as Alex Sherstinsky did).
- Removed InvoiceItem class since it doesn't exist (anymore) in Zoho, and replaced it with LineItem - Fixed error in to_hash that forced any class into ZohoInvoice::Invoice, this now checks the class - Fixed error (probably due to change by Zoho) in save of base object result.body => result.env.body - Expanded the mapping after an object is saved to Zoho so all values that are returned in the response (result.env.body) are mapped back to the known attributes. This will lower the number of calls needed to the API. After you save an invoice, it will now automatically fill the invoice_number from Zoho (as well as other values). - Changed the attributes of LineItem so they match the ones returned by Zoho. Used READ_ATTRIBUTES (similar as Alex Sherstinsky did).
…BUTES similar to other classes.
…mimosa-master Conflicts: lib/zoho_invoice/contact.rb
Fix unnecessary substitution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.