Skip to content

feat: use icon for dictionary audio playback #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binamkayastha wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: use icon for dictionary audio playback #239

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3513880
feat: use icon for dictionary audio playback
binamkayastha Oct 4, 2025
983768f
refactor: share audio playback hook
binamkayastha Oct 5, 2025
a31b328
Address comments
binamkayastha Dec 22, 2025
18aabf4
Cleanup code
binamkayastha Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 45 additions & 7 deletions nepalingo-web/src/components/SearchResponseCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,42 @@
import { Meaning } from "@/hooks/useDictionary";
import React from "react";
import React, { useEffect, useState } from "react";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { faVolumeHigh } from "@fortawesome/free-solid-svg-icons";

const SearchResponseCard = ({ meaning }: { meaning: Meaning }) => {
const [audio, setAudio] = useState<HTMLAudioElement | null>(null);

useEffect(() => {
return () => {
if (audio) {
audio.pause();
audio.currentTime = 0;
}
};
}, [audio]);

const handlePronunciation = (event: React.MouseEvent<HTMLButtonElement>) => {
event.stopPropagation();

if (!meaning.audio?.uri) {
return;
}

if (audio) {
if (!audio.paused) {
audio.pause();
audio.currentTime = 0;
} else {
audio.currentTime = 0;
void audio.play();
}
} else {
const newAudio = new Audio(meaning.audio.uri);
setAudio(newAudio);
void newAudio.play();
}
Copy link
Member Author

@binamkayastha binamkayastha Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same/similar code as the one in Card.tsx. Can we dry up the audio logic so it's not a repeat in this file and the Card file? Let me know if you have questions

};

return (
<div
key={meaning.meaningOriginal}
Expand All @@ -19,12 +54,15 @@ const SearchResponseCard = ({ meaning }: { meaning: Meaning }) => {
</p>
)}
</div>
{meaning.audio && (
<audio
controls
src={meaning.audio.uri}
className="max-w-28 "
></audio>
{meaning.audio?.uri && (
<button
type="button"
onClick={handlePronunciation}
className="self-start text-white text-2xl transition-colors hover:text-primary focus-visible:outline-none"
aria-label={`Play pronunciation for ${meaning.meaningOriginal}`}
>
<FontAwesomeIcon icon={faVolumeHigh} />
</button>
)}
</div>
<div className="flex flex-row flex-wrap gap-2 mt-2">
Expand Down