[codex] Fix constraint violation logging#27
Merged
Conversation
96d801b to
d56c5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix W&B constraint violation logging so equality tolerances are assigned from each constraint row rather than from a zipped Lagrange-multiplier equality mask.
Root Cause
AugmentedLagrangianNonsmooth.is_equality()is ordered by Lagrange multiplier, whileprog.GetAllConstraints()is ordered by constraint object. A two-sided inequality contributes two inequality multiplier entries, so zipping constraints withis_equality()can shift later equality constraints ontoFalsemask entries. In that case endpoint equalities are checked with the stricter inequality tolerance.Changes
lag_idxseparately for multiplier/residue indexing.lb == ub).Validation
python3 -m py_compile robot_payload_id/optimization/nevergrad_augmented_lagrangian.pyFull Drake runtime reproduction was not run in this scratch environment because
pydrakeis not installed.