fix: prevent duplicate og:type when set via extra_custom_props#275
Open
danishashko wants to merge 2 commits into
Open
fix: prevent duplicate og:type when set via extra_custom_props#275danishashko wants to merge 2 commits into
danishashko wants to merge 2 commits into
Conversation
Member
|
@danishashko Hi! Thanks for opening this: are you up to write some test for this? Ther's something already written in the issue you linked.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264
When
extra_custom_propsalready contains anog:typeproperty, the template was still rendering theog_type/object_typefield separately, which produced a duplicate<meta property="og:type">tag. This breaks Open Graph validators that expect exactly oneog:type.Changes:
has_og_type_in_custom_props()method toMetaclass inviews.pythat checks whetherog:typeis already defined inextra_custom_propsmeta.htmltemplate to skip the standardog:typeoutput when that method returnsTrue, letting the custom props version take precedenceThe existing behavior is unchanged for anyone who doesn't set
og:typeviaextra_custom_props.